Differences

This shows you the differences between two versions of the page.

--- plugin:inlineeditor [2011-11-04 23:01] – [Installation] double underscore in 'dw__editform' and increased indent rikblok
+++ plugin:inlineeditor [2019-01-09 21:59] (current) – Corrected downloadurl, mirror failed LarsDW223
@@ Line 1: / Line 1: @@
 ====== inlineeditor Plugin ======
----- pluginnews ----
-headline: Plugins by same author
-style: sameauthor
-----
 ---- plugin ----
@@ Line 14: / Line 10: @@
 depends    :
 conflicts  : dw2pdf, odt
-similar    : quickedit, dblclickedit
+similar    : fastwiki, quickedit, dblclickedit
 tags       : ajax, editing, inline, javascript
-downloadurl:http://sourceforge.net/projects/dokuineditor/files/inlineeditor.zip/download
+downloadurl: https://sourceforge.net/projects/dokuineditor/files/latest/download
-bugtracker :
+bugtracker : http://sourceforge.net/p/dokuineditor/tickets/
 sourcerepo : http://sourceforge.net/p/dokuineditor/code/
 donationurl:
@@ Line 39: / Line 35: @@
 ====== Installation ======
+Search and install the plugin using the [[plugin:extension|Extension Manager]] or manually with the download from the [[http://sourceforge.net/projects/dokuineditor/files/inlineeditor.zip/download|SourceForge Mirror]]. Refer to [[:Plugins]] on how to install plugins manually.
-Install the plugin using the [[plugin:plugin|Plugin Manager]] and the download URL above, which points to latest version of the plugin. Refer to [[:Plugins]] on how to install plugins manually.
 Then to make the toolbar work, you need to make a small change to the /lib/scripts/linkwiz.js
+FIXME : don't work in 2012-01-25 "Angua"
 Change
@@ Line 97: / Line 93: @@
 Thanks for the comment. Sounds like a better implementation. --Simon
+----
 It seams that this inlineeditor doesn't work with dw2pdf. If I enable the inlineeditor plugin, the output of dw2pdf show the editpage from inlineeditor after every section.
 -- Gerold
+----
 We really like this plugin-- very convenient to make quick corrections.  And it's helped my team warm up to sections, which has been an issue before!  But... it doesn't seem to work in IE8, which everyone but me uses.  The editor is displayed OK, but clicking the "save" button throws a Javascript error "Object doesn't support this property or method" in js.php?tseed=1313700839, line 1 character 68346.  Which is impossible for me to track down-- the JS is minimized and not readable. --Randy Whitaker 8/24/2011
@@ Line 133: / Line 132: @@
 function quickedit_save(id, range, page)
 {
-	pl_si.sack.onCompletion = quickedit_save_cb;
+    pl_si.sack.onCompletion = quickedit_save_cb;
     pl_si.sack.URLString = '';
     pl_si.id=id;
@@ Line 140: / Line 139: @@
     var text=document.getElementById("wiki__text").value;
     var sub=document.getElementById("editsummary"+id+page).value;
-	pl_si.sack.runAJAX('call=save_page&range='+range+'&page='+page+'&text='+text.replace(/&/g, '%26')+'&sub='+sub.replace(/&/g, '%26')+'&minor='+minor);
+    pl_si.sack.runAJAX('call=save_page&range='+range+'&page='+page+'&text='+text.replace(/&/g, '%26')+'&sub='+sub.replace(/&/g, '%26')+'&minor='+minor);
 }
 </code>
@@ Line 147: / Line 146: @@
 Hi fumigator! Thanks for the help. I have now updated the plugin with your changes. It should now work for all browsers I hope? If anybody wants to help developing further on this plugin, then please drop me a line (my email is above). -- Simon 09/01/2011
+----
  We found another fairly severe issue when using this plugin which can result in content loss.  When editing a page using the normal "edit page" button, if I click "preview", and then double-click inside the preview of the page, the inline editor pops up, in addition to the normal editor, but the content in the inline editor textarea is messed up-- it is not what's in the section clicked on.  The biggest issue with this unintended behavior is if you click the save button on the inline editor, the entire page is wiped out, except what's in the inline editor's textarea.  I've done this a couple of times-- I forget I'm looking at a preview instead of the normal page, see something that needs changing, double-click it (since I'm so used to using inline editor now), and if I don't realize what's happening, I save and wipe out the page.  The best way to fix this would be to remove the double-click functionality when the page is is a preview (have no idea if that's possible). -[[user>fumigator]] 8/31/2011
 Hi fumigator. Sorry for late answer, but I do not check this page every day. The preview bug is now fixed. -- Simon 10/09/2011
+----
+Thanks for the neat plugin, Simon!  Unfortunately, it seems to eat '+' signs so it doesn't work for me in my math-intensive wiki (using [[doku>plugin:jsmath]]).  Before editing I might have ''a + b'' but after saving it becomes ''a   b''.  It looks like the plus-symbol needs to be encoded before save.  There could be other characters that also need to be encoded so I changed
+<code javascript>
+    pl_si.sack.runAJAX('call=save_page&range='+range+'&page='+page+'&text='+text.replace(/&/g, '%26')+'&sub='+sub.replace(/&/g, '%26')+'&minor='+minor);
+</code>
+to
+<code javascript>
+    pl_si.sack.runAJAX('call=save_page&range='+range+'&page='+page+'&text='+encodeURIComponent(text)+'&sub='+encodeURIComponent(sub)+'&minor='+minor);
+</code>
+Do you foresee any problems with that?  Thanks. --- [[user>rikblok|Rik Blok]] //2011/11/05 07:51//
+----
+\\
+\\
+\\
+Hello,
+I tried to implement inlineeditor in Dokuwiki Angua but I cannot find the text to be changed in "linkwiz.js". Anyway without the changes I cannot get it working in this release.
+Chris Nelis 20120216
+----
+Hi, same for me too nothing to change in .js and doesn't do anything at all. Julian Knight, 2012-03-06
+Even worse, it uses old code (from quickedit?) that is DEPRECATED and so triggers lots of warning messages - I've stopped using it. Instead I've implemented a quick and dirty jQuery hack:
+<code>
+jQuery(function(){
+  jQuery('#bodyContent').dblclick(function() {
+    window.location = '?do=edit';
+  });
+});
+</code>
+This seems to work well enough for me though you should not double-click when the editor is already open as it will reopen losing your changes (you do at least get a warning).
+Julian Knight 2012-03-15
+===
+Hi,
+Yes. The inlineeditor doesn't work in the new dokuwiki version. I don't have time to update the plugin at the moment. Anybody who would like to help are very welcome! @Julian, I like your suggestion, but it does not solve the basic issue the inline tries to solve; namely that when you hit the back button after editing you end up in the editor window (not as you should the previous wiki page).
+Simon-Shlomo Poil 2012-05-18
+==== Messes with Meta data ====
+**Cautionary note:** this plugin will cause the meta data, specifically the description in the meta data, to be filled with HTML with embedded Javascript in it **on every page you modify**.  The resulting mess is something I'm still trying to clean up.
+I only just found about this problem when I was trying to display the "desc" column using the plugin "dir" and it was breaking the page because it just dumps whatever is in the meta field "description" into the listing and all the DIVs and javascript causes a meltdown.
+-[[user>fumigator]] 8/30/2011