For the release of 2020 big parts of DokuWiki are refactored.

A lot of code has been marked as deprecated. Which means it will be removed in future releases of DokuWiki. While this does (normally) not cause plugins to malfunction now, it may lead to nasty surprises after future updates.

Plugin/template authors can easily check if they use any deprecated functions, classes or methods:

• enable the allowdebug setting in the Configuration Manager
• use the plugin
• check data/cache/debug.log for any information about deprecated calls caused by the plugin.

Below, you find lists with renamed, changed and moved parts of DokuWiki. Some examples are provided for easier update of plugins and templates. References to codesearch.dokuwiki.org can help locate it usage.

Code changes: d443762baf and 2686

Search usage: "inc\/JSON.php", "json->encode" and "json->decode"

// Remove always the require, since years already autoloaded 
// and file is now removed as well
- require_once DOKU_INC . 'inc/JSON.php';
 
- $json = new JSON;
- $str = $json->encode($data);
- $data = $json->decode($str);
+ $str = json_encode($data);
+ $data = json_decode($str);
 
 
- $json = new JSON(JSON_LOOSE_TYPE);
- $str = $json->encode($data);
- $data = $json->decode($str);
+ $str = json_encode($data, true);
+ $data = json_decode($str, true);

e.g. Doku_Handler_List is replaced by dokuwiki\Parsing\Handler\Lists. Needed code update:

//import at begin of the file:
+ use dokuwiki\Parsing\Handler\Lists;
 
//at place of usage:
- class Doku_Handler_Creole_List extends Doku_Handler_List {
+ class Doku_Handler_Creole_List extends Lists {

Tip: when using a IDE, like Intellij idea, it will suggest a lot of the imports if you use the class names.

The following classes are renamed:

Variables are not available anymore:

• $handler->status[]
• $handler->CallWriter

Functions renamed:

• $handler->_addCall()
• $handler->_finalize()

Search usage: status, CallWriter and _addCall, _finalize

Replacements:

- $status = $handler->status['section']
+ $status = $handler->getStatus('section')
 
- $handler->status['section'] = true
+ $handler->setStatus('section', true)

case DOKU_LEXER_ENTER:
-   $ReWriter = new Doku_Handler_Creole_List($handler->CallWriter);
-   $handler->CallWriter = & $ReWriter;
+   $ReWriter = new Doku_Handler_Creole_List($handler->getCallWriter());
+   $handler->setCallWriter($ReWriter);
 
case DOKU_LEXER_EXIT:
-   $handler->CallWriter->process();
-   $ReWriter = & $handler->CallWriter;
-   $handler->CallWriter = & $ReWriter->CallWriter;
+   $ReWriter = $handler->getCallWriter();
+   $handler->setCallWriter($ReWriter->process());

- $handler->_addCall('list_close', array(), $pos);
+ $handler->addCall('list_close', array(), $pos);

Note: some general addCall() can be replaced by the specific functions like header(), eof(), hr(), strong(), emphasis(), underline(), etc etc. Could be worth a check, however there should be typical a reason that these specific functions were not used.

Renamed variables: Handler and Lexer to handler and lexer. (maybe no difference in practice due to case-insensitivity)

Changed visibility, these variables are now protected: handler, lexer, modes, connected. The handler can be set via the constructor. There are no setters or getters for the others.

- $parser = new Doku_Parser();
- $parser->Handler = $handler;
+ $parser = new Parser($handler);

Variables and functions are not available anymore:

• $lexer->_mode
• function Doku_Lexer_Escape($str)

Search usage: _mode, Doku_Lexer_Escape and _dispatchTokens

- $lexer->_mode->getCurrent();
+ $lexer->getModeStack()->getCurrent();

- $str = Doku_Lexer_Escape($str);
+ $str = \dokuwiki\Parsing\Lexer\Lexer::escape($str);

Other renamed protected functions of Lexer: _dispatchTokens(), _isModeEnd(), _isSpecialMode(), _decodeSpecial(), _invokeParser() and _reduce().

Renamed protected functions of ParallelRegex: _getCompoundedRegex(), _getPerlMatchingFlags().

All UTF-8 functions are moved and renamed. Refactored mostly in 2780.

Class for handling UTF-8 in filenames. Renamed functions:

Changed visibility, these variables are now protected and have new setters/getters:

? CHECK: NO SETTER FOR nocache, while used in plugins

- $time = $cache->_time 
+ $time = $cache->getTime())
 
- $cache = new cache_renderer($ID, $file, 'xhtml');
- $useCache = $cache->_nocache
+ $cache = new CacheRenderer($ID, $file, 'xhtml');
+ $useCache = $cache->isNoCache()
 
- $cache->_event = $event
+ $cache->setEvent($event)
- $event = $cache->_event 
+ $event = $cache->getEvent()

Renamed and moved classes:

Renamed and moved classes:

Renamed and refactored in separated classes:

Examples:

- $subscription = new Subscription();
- $success = $subscription->send_register($login, $fullname, $email);
+ $subscription = new RegistrationSubscriptionSender();
+ $success = $subscription->sendRegister($login, $fullname, $email);
 
- $sub = new Subscription();
- $info['subscribed'] = $sub->user_subscription();
+ $subManager = new SubscriberManager();
+ $info['subscribed'] = $subManager->userSubscription();
 
- $subscription = new Subscription();
- $success = $subscription->send_diff($to, $tpl, $id, $rev, $summary);
+ $subscription = new PageSubscriptionSender();
+ $success = $subscription->sendPageDiff($to, $tpl, $id, $rev, $summary);
 
 
- $subscription = new Subscription();
- $success = $subscription->send_media_diff($subscriber_mail, $template, $id, $rev);
+ $subscriptionSender = new MediaSubscriptionSender();
+ $success = $subscriptionSender->sendMediaDiff($subscriber_mail, $template, $id, $rev);
 
- $subscription = new Subscription();
- $success = $subscription->isenabled();
- $success = $subscription->subscribers($page, $user, $style, $data);
- $success = $subscription->add($id, $user, $style, $data)
- $success = $subscription->remove($id, $user, $style, $data)
- $success = $subscription->user_subscription($id, $user)
- $subscription->notifyaddresses($data)
+ $manager = new SubscriberManager();
+ $success = $manager->isenabled();
+ $success = $manager->subscribers($page, $user, $style, $data);
+ $success = $manager->add($id, $user, $style, $data);
+ $success = $manager->remove($id, $user, $style, $data);
+ $success = $manager->userSubscription($id, $user);
+ $manager->notifyAddresses($data);
 
- $subscription = new Subscription();
- $success = $subscription->send_bulk($page);
+ $subscriptionSender = new BulkSubscriptionSender();
+ $success = $subscriptionSender->sendBulk($page);

Renamed and moved classes:

Visibility changed to protected variables: connections, boundary

Visibility changed to protected and renamed functions: _ssltunnel, _sendData, _readData, _readLine, _debug _debug_html, _debug_text, _time, _parseHeaders, _buildHeaders, _getCookies, _postEncode, _postMultipartEncode, _uniqueConnectionId. All the underscored are removed from the function names, and two names changed more: debugHtml, debugText.

Renamed and moved classes:

Renamed and moved classes:

signatures in action.php

- function alwaysHide(Doku_Event &$event, $params) { + function alwaysHide(Doku_Event $event, $params) {

and syntax.php

Lot of plugins uses the following older code. Today these are already included via the core or not needed anymore.

The following code is only needed if a file has main code that is executed. Otherwise it can be left out.

- if(!defined('DOKU_INC')) die('meh.');

Code beautification. The defines are already in core, so can be deleted. Further these code beautifications are not needed anymore with current tools.

- // Some whitespace to help View > Source
- if(!defined('DOKU_LF')) define ('DOKU_LF', "\n");
 
- // Some whitespace to help View > Source
- if(!defined('DOKU_TAB')) define ('DOKU_TAB', "\t");
 
- if(!defined('NL')) define('NL',"\n");

This directory is set in the core, not needed per plugin.

- if(!defined('DOKU_PLUGIN')) {
-     define('DOKU_PLUGIN',DOKU_INC.'lib/plugins/');
- }

Scripts includes such as require and require_one are not needed for all the DokuWiki files or the typical plugin files. DokuWiki has an autoloader. More and more parts of the core use namespaces. Please use them, see autoloader how these are related to your files.

- require_once(DOKU_PLUGIN.'syntax.php');
- require_once(DOKU_PLUGIN.'action.php');
- require_once(DOKU_PLUGIN.'admin.php');
- etc
 
- require_once DOKU_INC . 'inc/parser/lexer.php';
- require_once DOKU_INC . 'inc/parser/handler.php';